814510 - Downloads Summary icon needs to be revisited

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

The icon displayed on the left side of the Downloads Summary is being taken toolkit/themes/*stripe/mozapps/downloads/.

We might want to move those to browser/themes/*stripe/downloads

We also need to create a scaled up version for Retina displays on pinstripe.

We also need to replace, or resize the ones being used on winstripe - the current ones are 24x24, being scaled up to 32x32, which makes them look fuzzy.

Comment 1

[Marco Bonardo [:mak]]

Looks like shorlander just won another bug

Comment 2

[Marco Bonardo [:mak]]

(In reply to Mike Conley (:mconley) from comment #0)
> We might want to move those to browser/themes/*stripe/downloads

Well, if it's being used by toolkit code I don't think we want to move it, we may want to provide a different icon for browser.
mxr link to the icon?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Marco Bonardo [:mak] from comment #2)
> (In reply to Mike Conley (:mconley) from comment #0)
> > We might want to move those to browser/themes/*stripe/downloads
> 
> Well, if it's being used by toolkit code I don't think we want to move it,
> we may want to provide a different icon for browser.

Er, yes - sorry, that's what I meant. I wasn't clear.

> mxr link to the icon?

gnomestripe: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/gnomestripe/mozapps/downloads/downloadIcon.png

pinstripe: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/mozapps/downloads/downloadIcon.png

winstripe - classic: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/downloads/downloadIcon.png

winstripe - aero: https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/downloads/downloadIcon-aero.png

Comment 4

[u428464]

It could also be modernized and unified on various platforms.

Comment 5

[Marco Bonardo [:mak]]

Gentle UX-ping, we are still waiting for the new icon.

Comment 6

[u428464]

I think the icon that will be used can be seen on this mockup, but I'm not sure : http://cl.ly/image/1o0J1K2J3T0V

Comment 7

[Stephen Horlander [:shorlander]]

Attachment: Download Summary Icon - OSX

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Download Summary Icon - Windows

Comment 9

[Stephen Horlander [:shorlander]]

Attachment: Download Summary Icon - Linux

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 on Windows 7 Aero

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 on Windows XP Luna

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 on OSX

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1 on Ubuntu

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1

Removing unneeded size constraints on the icon in winstripe.

Comment 16

[Marco Bonardo [:mak]]

Comment on attachment 694960 [details] [diff] [review]
Patch v1.1

Review of attachment 694960 [details] [diff] [review]:
-----------------------------------------------------------------

It looks a bit too large in Aero... though I suppose Stephen verified that, in case we can replace the icon easily at any time, let's pave the way.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acb02d013052

Mike, can you make sure that you've got hg configured to generate proper patch metadata in the future? It makes life easier when you need someone else to checkin a patch for you.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ryan VanderMeulen [Intermittent Availability Until Jan. 2] from comment #17)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/acb02d013052
> 
> Mike, can you make sure that you've got hg configured to generate proper
> patch metadata in the future? It makes life easier when you need someone
> else to checkin a patch for you.

Ack - sorry about that. Was away from my development machine. My apologies.

Comment 19

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/mozilla-central/rev/acb02d013052